Develop #5
Merged
Develop #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced SecureTokenStorage for encrypted token management and updated LoginViewModel to support token persistence and auto-login. Added IsSynced property to key models (Account, Budget, Category, Transaction, UserSettings, BudgetCategory) to track synchronization status. Updated AuthService base address.
…torage Introduces a new HomeViewModel class inheriting from ObservableObject for MVVM support. Also reorders using directives in SecureTokenStorage.cs for consistency.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces security enhancements and synchronization tracking into the FinTrack project by integrating secure token storage in the authentication workflow and adding an IsSynced property to various models.
- Integrates SecureTokenStorage into LoginViewModel to automatically log in users with saved tokens.
- Adds an IsSynced property to multiple models to track synchronization status.
- Updates AuthService base URL and introduces a placeholder HomeViewModel.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| FinTrack/ViewModels/LoginViewModel.cs | Integrates secure token login and token saving in authentication flow |
| FinTrack/ViewModels/HomeViewModel.cs | Adds a placeholder HomeViewModel class |
| FinTrack/Services/AuthService.cs | Updates the AuthService base URL |
| FinTrack/Models/UserSettingsModel.cs | Adds IsSynced property for sync status tracking |
| FinTrack/Models/TransactionModel.cs | Adds IsSynced property for sync status tracking |
| FinTrack/Models/CategoryModel.cs | Adds IsSynced property for sync status tracking |
| FinTrack/Models/BudgetModel.cs | Adds IsSynced property for sync status tracking |
| FinTrack/Models/BudgetCategoryModel.cs | Adds IsSynced property for sync status tracking |
| FinTrack/Models/AccountModel.cs | Adds IsSynced property for sync status tracking |
| FinTrack/Core/SecureTokenStorage.cs | Implements secure token storage using ProtectedData |
| if (!string.IsNullOrEmpty(token)) | ||
| { | ||
| SessionManager.SetToken(token); | ||
| MessageBox.Show("Giriş başarılı! Token kullanıldı.", "Bilgi", MessageBoxButton.OK, MessageBoxImage.Information); |
There was a problem hiding this comment.
[nitpick] Consider decoupling UI messaging from the ViewModel by using an event or messaging service instead of directly calling MessageBox.Show to improve testability and separation of concerns.
| } | ||
| catch (Exception ex) | ||
| { | ||
| Console.WriteLine($"Error saving token: {ex.Message}"); |
There was a problem hiding this comment.
Consider replacing Console.WriteLine with a proper logging framework to improve error tracking and maintainability in production environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several key updates to the
FinTrackproject, including a new secure token storage mechanism, synchronization status tracking for models, and enhancements to authentication workflows. Additionally, minor changes were made to the base address of theAuthServiceand a placeholderHomeViewModelwas added.Security and Authentication Enhancements:
SecureTokenStorageclass: Implements secure storage for user tokens usingProtectedDatafor encryption and decryption, with methods to save, retrieve, and clear tokens. (FinTrack/Core/SecureTokenStorage.cs)LoginViewModel: IntegratedSecureTokenStorageto automatically log in users with a saved token and to save tokens upon successful login. (FinTrack/ViewModels/LoginViewModel.cs) [1] [2]Model Synchronization:
IsSyncedproperty: Introduced abool IsSyncedproperty to track synchronization status for the following models:AccountModel(FinTrack/Models/AccountModel.cs)BudgetCategoryModel(FinTrack/Models/BudgetCategoryModel.cs)BudgetModel(FinTrack/Models/BudgetModel.cs)CategoryModel(FinTrack/Models/CategoryModel.cs)TransactionModel(FinTrack/Models/TransactionModel.cs)UserSettingsModel(FinTrack/Models/UserSettingsModel.cs)Minor Updates:
AuthServicebase address: Changed the base URL fromhttp://localhost:5246/tohttp://localhost:5000/. (FinTrack/Services/AuthService.cs)HomeViewModel: Created a placeholderHomeViewModelclass inheriting fromObservableObject. (FinTrack/ViewModels/HomeViewModel.cs)