Develop #3
Merged
Develop #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r UX Introduces OtpVerificationViewModel and integrates OTP verification into the navigation flow. Refactors LoginViewModel and RegisterViewModel for clearer property naming and command binding, adds password visibility toggles with new EyeButtonStyle, and updates related XAML views for improved user experience and maintainability.
Introduced ForgotPasswordView and its ViewModel, enabling users to request a password reset from the login screen. Updated MainViewModel to handle navigation to and from the forgot password view. Modified LoginWindow.xaml to include the new view, and adjusted related navigation logic for a smoother user experience.
Introduced fade and scale-in animations on load for ForgotPasswordView, LoginView, OtpVerificationView, and RegisterView to enhance user experience with smooth transitions.
…Track Introduced ApplicationRecognizeSlideView and ApplicationRecognizeSlideViewModel to provide an onboarding experience for new users. Updated MainViewModel to show the onboarding slides on startup and handle navigation to the login view. Added chatbot image asset, registered new resources in the project file, and included a secondary button style. Cleaned up unused usings in several files and updated LoginWindow.xaml to support the new onboarding view.
…in folder Renamed and reorganized login-related ViewModels and Views into dedicated Login subfolders for improved project structure and maintainability. No code changes were made, only file moves and renames.
…mponents Introduces MainWindow, TopBarView, and BottomBarView with corresponding ViewModels and XAML files. Adds new icon assets and updates ModernStyles.xaml with new styles for navigation and accent buttons. Refactors ViewModels and Views by moving login-related files to the main ViewModels and Views directories. Updates FinTrack.csproj to include new resources.
Introduced a function to handle and validate user input, improving the robustness of the input processing workflow.
Implemented additional functionality on the user profile page, including support for editing user details and updating the profile picture. Refactored related components for better maintainability.
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces significant updates to the FinTrack application including new ViewModels (OtpVerificationViewModel, ForgotPasswordViewModel, and ApplicationRecognizeSlideViewModel), several new UI views (e.g. TransactionsView, TopBarView, RegisterView, LoginView, etc.), and updates to the project structure and resources.
- New navigation flow starts with the onboarding slides and integrates registration, OTP verification, and password reset.
- Updated resource definitions and modern style components ensure a consistent, animated, and responsive UI across the application.
Reviewed Changes
Copilot reviewed 49 out of 63 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Various XAML view files | Added new UI views with animations, updated styles, and resource links. |
| ViewModel files (Login, Register, OTP, etc.) | Introduced multiple ViewModels with new commands and property bindings. |
| MainViewModel.cs | Updated navigation wiring to incorporate new ViewModels and starting view. |
| FinTrack.csproj | Updated resource references and dependency additions. |
Comments suppressed due to low confidence (1)
FinTrack/ViewModels/LoginViewModel.cs:10
- [nitpick] Property names like 'email_LoginView_TextBox' and 'password_LoginView_TextBox' are overly verbose. Consider using more concise naming (e.g. Email and Password) to enhance code readability and maintainability.
private string? email_LoginView_TextBox;
| _registerViewModel.NavigateToLoginRequested += () => CurrentViewModel = _loginViewModel; | ||
|
|
||
| CurrentViewModel = _loginViewModel; | ||
| _otpVerificationViewModel.NavigateToHomeRequested += () => CurrentViewModel = _loginViewModel; |
There was a problem hiding this comment.
OTP verification is intended to navigate to the home view upon successful verification, but the wiring currently sets the CurrentViewModel to the login view instead. Update this to navigate to the appropriate home view model.
| if (string.IsNullOrWhiteSpace(OtpCode) || OtpCode.Length != 6) | ||
| { | ||
| IsOtpCodeValid = false; | ||
| MessageBox.Show("Lütfen geçerli bir OTP kodu girin."); |
There was a problem hiding this comment.
Calling MessageBox.Show directly in the viewmodel can hinder unit testing and violates MVVM separation of concerns. Consider abstracting this UI notification using a dialog service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the
FinTrackapplication, including the addition of new ViewModels, enhancements to existing ViewModels, and updates to the project structure and resources. The changes aim to improve functionality, streamline navigation, and enhance user experience.New ViewModels and Features:
ApplicationRecognizeSlideViewModelto manage onboarding slides with titles, descriptions, and icons, providing a guided introduction to the application. It includes navigation logic to transition to the login view.OtpVerificationViewModelto handle OTP verification with validation logic and navigation to the home view upon successful verification.ForgotPasswordViewModelto manage password reset functionality, including email validation and navigation back to the login view.Enhancements to Existing ViewModels:
LoginViewModelandRegisterViewModelto use descriptive property names tied to UI elements, improving code readability and maintainability. Added password visibility toggle functionality. [1] [2]MainViewModelto integrate the new ViewModels (OtpVerificationViewModel,ForgotPasswordViewModel, andApplicationRecognizeSlideViewModel) and manage navigation between them. The onboarding slides are now the default starting view.Resource and Project Updates:
LiveChartsCore.SkiaSharpView.WPFfor potential charting functionality.Code Cleanup:
usingdirectives in multiple files to improve code clarity. [1] [2]Placeholder ViewModels:
BottomBarViewModel,DashboardViewModel, andTopBarViewModelas potential future implementations. [1] [2] [3]