Develop

[EnesEfeTokta]

This pull request introduces significant changes to the project, primarily focused on renaming the namespace from FinTrack to FinTrackForWindows and adding new DTOs for accounts, budgets, and chats. These updates aim to align the codebase with a more platform-specific naming convention and enhance data transfer capabilities.

Namespace Renaming:

• Updated the namespace throughout the project from FinTrack to FinTrackForWindows, affecting multiple files, including App.xaml, App.xaml.cs, and core classes like ISecureTokenStorage, SessionManager, and TokenValidator. [1] [2] [3] [4] [5]

Core Enhancements:

• Added FirstName and LastName properties to NewUserInformationManager for better user data management.

DTO Additions:

• Introduced new DTOs for accounts, including AccountCreateDto, AccountDto, AccountResponseDto, and AccountUpdateDto, to standardize data structures for account-related operations. [1] [2] [3] [4]
• Added budget-related DTOs, such as BudgetCreateDto, BudgetDto, BudgetCategoryCreateDto, BudgetCategoryDto, and their update counterparts, to facilitate budget management. [1] [2] [3] [4] [5] [6]
• Created ChatRequestDto to handle chat-related requests.

These changes provide a clearer structure and improve the maintainability and scalability of the codebase.

[Copilot]

Pull Request Overview

This pull request implements a comprehensive namespace change from FinTrack to FinTrackForWindows across the entire codebase and introduces significant new functionality with DTOs for API integration. The changes aim to align the codebase with a more platform-specific naming convention and enhance data transfer capabilities between the client and server.

• Namespace refactoring from FinTrack to FinTrackForWindows across all files
• Addition of comprehensive DTO classes for accounts, budgets, transactions, and chat functionality
• Enhanced user registration flow with separate first name and last name fields
• Updated API service configuration and endpoints

Reviewed Changes

Copilot reviewed 159 out of 160 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
README.md	Updated project title, license change from MIT to GPL, and repository URL correction
Views/.xaml and Views/.xaml.cs	Namespace updates and UI improvements including registration form changes
ViewModels/*.cs	Namespace updates and integration with new API services and DTOs
Models/*.cs	Namespace updates and model structure improvements
Dtos/*.cs	New DTO classes for API communication (accounts, budgets, transactions, chat)
Services/*.cs	Updated API service endpoints and authentication flow
Core/*.cs	Namespace updates and addition of FirstName/LastName properties
FinTrackForWindows.csproj	Package version updates and project file renaming

Files not reviewed (1)

• FinTrack/Migrations/20250626151252_InitialCreate.Designer.cs: Language not supported

Comments suppressed due to low confidence (2)

README.md:110

• The repository URL should reflect the new project name 'FinTrackForWindows' to be consistent with the namespace changes throughout the project.

    git clone https://github.com/EnesEfeTokta/FinTrack.git

FinTrack/ViewModels/BudgetViewModel.cs:104

• The variable 'selectedBudget' should use Pascal case 'SelectedBudget' to match C# naming conventions and be consistent with the property name.

                    await _apiService.PutAsync<BudgetModel>($"Budgets/{selectedBudget.Id}", budgetDto);

[Copilot]

[nitpick] The FullName generation logic removes spaces and joins with underscore, which may not be the intended format for a full name. Consider using a space separator or documenting this specific formatting requirement.

Suggested change

	NewUserInformationManager.FullName = FirstName_RegisterView_TextBox.Replace(" ", "").Trim() + "_" + LastName_RegisterView_TextBox.Replace(" ", "").Trim();
	NewUserInformationManager.FullName = FirstName_RegisterView_TextBox.Trim() + " " + LastName_RegisterView_TextBox.Trim();

[Copilot]

The condition logic is inverted. The code should execute the registration when fields are NOT null/empty, but the condition checks if they ARE null/empty and then proceeds with registration.

Suggested change

	if (string.IsNullOrEmpty(NewUserInformationManager.FirstName) ||
	string.IsNullOrEmpty(NewUserInformationManager.LastName) ||
	string.IsNullOrEmpty(NewUserInformationManager.Email) ||
	string.IsNullOrEmpty(NewUserInformationManager.Password))
	if (!string.IsNullOrEmpty(NewUserInformationManager.FirstName) &&
	!string.IsNullOrEmpty(NewUserInformationManager.LastName) &&
	!string.IsNullOrEmpty(NewUserInformationManager.Email) &&
	!string.IsNullOrEmpty(NewUserInformationManager.Password))

[Copilot]

The code reads from the response stream on line 95 but then calls GetFromJsonAsync which will try to read the already consumed stream, potentially causing issues. Either use the stream approach or the GetFromJsonAsync approach, not both.

Suggested change

var strean = await response.Content.ReadAsStreamAsync();

[Copilot]

The code creates a JSON payload on lines 168-169 but then doesn't use it, instead using PostAsJsonAsync directly with the data object. The manual JSON serialization should be removed.

Suggested change

	var jsonPayload = JsonSerializer.Serialize(data);
	var content = new StringContent(jsonPayload, System.Text.Encoding.UTF8, "application/json");