Skip to content

UofT-DSI | LCR - Assignment 1#1

Open
Empress-star wants to merge 1 commit intomainfrom
assignment_one
Open

UofT-DSI | LCR - Assignment 1#1
Empress-star wants to merge 1 commit intomainfrom
assignment_one

Conversation

@Empress-star
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I've completed the code as requested, creating a knn model for the wine data.

What did you learn from the changes you have made?

I was able to practice the method for creating training and testing sets, as well as cross validating knn with a parameter grid.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

For question 1, there were a couple different approaches I could take. Using the info() method would have given all the answers, but amongst a number of other values, so I used shape to get the most precise answers with the code

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I found it challenging to write code that gave me the value of just the class column. I found that using the type() method would just tell me that it was a dataframe. I ended up using the info() method, which natively gives the dtype of all the columns

How were these changes tested?

Once I saved my changes, I reopened it and ran the file again to make sure all the code blocks worked

A reference to a related issue in your repository (if applicable)

Checklist

  • [ x] I can confirm that my changes are working as intended

Copy link

@fyellow fyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! You met all the criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants