Open
Conversation
fyellow
approved these changes
May 22, 2025
fyellow
left a comment
There was a problem hiding this comment.
Great job! You met all the criteria.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I've completed the code as requested, creating a knn model for the wine data.
What did you learn from the changes you have made?
I was able to practice the method for creating training and testing sets, as well as cross validating knn with a parameter grid.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
For question 1, there were a couple different approaches I could take. Using the info() method would have given all the answers, but amongst a number of other values, so I used shape to get the most precise answers with the code
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I found it challenging to write code that gave me the value of just the class column. I found that using the type() method would just tell me that it was a dataframe. I ended up using the info() method, which natively gives the dtype of all the columns
How were these changes tested?
Once I saved my changes, I reopened it and ran the file again to make sure all the code blocks worked
A reference to a related issue in your repository (if applicable)
Checklist