Open
Conversation
Not yet finished. - how do we mark that a character is in "learn" mode? - how do we render an idea? is there already a method for it? - how do we generate a new constructitemidea from a constructitemideadef?
Emperorlou
reviewed
Dec 23, 2020
| //make sure the student is still valid. Ensure that they're still in learn mode, and that they're still in the same location. | ||
|
|
||
| if(GameUtils.equals(student.getProperty("locationKey"), character.getProperty("locationKey")) == false) continue; | ||
| if(GameUtils.equals(student.getProperty("mode"), "LEARNING") == false) continue; //not sure if this is how we want to do this. |
Owner
There was a problem hiding this comment.
I don't think the player enters a different mode when doing an invention do they? So we would want to do it just like invention.
Collaborator
Author
There was a problem hiding this comment.
Normal inventions are just a long operation, which locks the character inventing. But in this case, we are affecting other characters. How do we mark the characters that are being taught, to prevent them from doing other things while they are being taught?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet finished.