Use same name attribute for every radio within the same radio-group#56
Open
renaudleo wants to merge 1 commit intoEmerson:masterfrom
Open
Use same name attribute for every radio within the same radio-group#56renaudleo wants to merge 1 commit intoEmerson:masterfrom
renaudleo wants to merge 1 commit intoEmerson:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed & Why
The
radiowidget uses anameattribute, but theradio-groupwidget doesn't actually pass that param toradio, so radio buttons in a radio group don't have any name attribute.Testing
List step-by-step how to test the changes.
radio-groupwidget