Allow empty string for optionValuePath on fm-select#43
Merged
g-cassie merged 5 commits intoEmerson:masterfrom Jan 18, 2016
Merged
Allow empty string for optionValuePath on fm-select#43g-cassie merged 5 commits intoEmerson:masterfrom
g-cassie merged 5 commits intoEmerson:masterfrom
Conversation
Collaborator
Author
|
These failures seem to also exist on master... I think there is something going on with Ember-Try. I noticed on @jelhan 's PRs that the builds were failing on beta - maybe this is biting us now? Edit: @Emerson I think you have may broken some of @jelhan 's tests when you added the fm-config.showErrorsByDefault property. |
Contributor
g-cassie
added a commit
that referenced
this pull request
Jan 18, 2016
Allow empty string for optionValuePath on fm-select
Owner
|
So nice to see the green "Passing" text again – thanks @g-cassie |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it possible to set
optionValuePath=''and have the entire object from the content list be set to the value of the property. This is a very common pattern with Ember-Data.This behaviour was working prior to 8feb869 when we switched over to the built in
gethelper. This restores the previous functionality and adds a test.