Corrected minor issues with raw versus interpreted patterns in lib.#3
Open
ryancmoon wants to merge 1 commit intoEmergingThreats:mainfrom
Open
Corrected minor issues with raw versus interpreted patterns in lib.#3ryancmoon wants to merge 1 commit intoEmergingThreats:mainfrom
ryancmoon wants to merge 1 commit intoEmergingThreats:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdf_lib.py - lines 56, 63, and 112. It looks like there is an invalid pattern here that can be interpreted correctly with raw binary (rb) vs regular binary (b) mode. There may be others in the list here that fail, but these three caused issues on my python 3.12 and python 3.15 installs using default re lib.
Feel free to disregard if this is not duplicating elsewhere, but I believe the change can be implemented without effecting matches based on testing so far.