Skip to content

Make the scale-rotate tool's commit behavior more consistent with that of other tools#2

Open
ethanjli wants to merge 12 commits intoEmergentStudios:masterfrom
ethanjli:feature/selection-scale-rotate-commit-button
Open

Make the scale-rotate tool's commit behavior more consistent with that of other tools#2
ethanjli wants to merge 12 commits intoEmergentStudios:masterfrom
ethanjli:feature/selection-scale-rotate-commit-button

Conversation

@ethanjli
Copy link

@ethanjli ethanjli commented Oct 6, 2021

Fixes:

  • Change the transformation matrix to be equal to a matrix constructed by right-multiplying a scaling matrix with a rotation matrix (see here for a visual representation), so that scaling and rotation parameters can be adjusted simultaneously between commits

Additions/changes:

  • Remove the behavior to automatically commit changes in the scale/rotate tool on blur/mouseup/enter events, and instead commit changes only from a new "Commit" button
  • Add a reset button for each slider in the tool. The other tools have easy reset, because their sliders can just be dragged all the way to the left. For the scale-rotate tool, the reset positions are in the middle of the sliders - so reset buttons help with usability.
  • Add two more tools to the Selection Rotate and Scale Mod, flipX and flipY, which allow mirroring the selection in the x-axis or the y-axis, respectively
  • Bump the script's version number from 0.4 to 0.5.1

@ethanjli ethanjli marked this pull request as ready for review October 27, 2021 06:34
@ethanjli
Copy link
Author

ethanjli commented Oct 27, 2021

At least a few members of LRAC (including myself) have been using this modification regularly over the past 3 weeks, and I haven't heard any issues yet, so I'm marking this PR as ready for review. Please let me know if there's anything I can do, or if you need any information from me, to make it easy to review this PR!

…mmit-button

Make the scale-rotate tool's commit behavior more consistent with that of other tools
// @match https://*.official-linerider.com/*
// @match http://localhost:8000/*
// @downloadURL https://github.com/EmergentStudios/linerider-userscript-mods/raw/master/selection-scale-rotate.user.js
// @downloadURL https://github.com/ethanjli/linerider-userscript-mods/raw/master/selection-scale-rotate.user.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this will exist in EmergentStudios/linerider-userscript-mods, the download URL should continue to point here, right?

Copy link
Author

@ethanjli ethanjli Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when I committed 71a3b35 I wasn't sure if this repo was still going to be maintained, or if I should start an actual fork. I'll change the download URL back when I also merge ethanjli#2 into this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've reverted the download URL and merged ethanjli#2 into this PR - please let me know if there's anything else I should do on this PR!

* Add checkboxes to mirror a selection along X or Y

* Revert download URL to upstream repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants