Skip to content

Conversation

@eugenevinitsky
Copy link

Summary

Merges the new data format architecture from PR #107 into the 3.0 branch.

Changes

  • New separated structures: Agent, RoadMapElement, TrafficControlElement (replaces Entity/MapEntity)
  • Log vs Sim state naming convention
  • Route information for path planning
  • Traffic light detection and skipping
  • New config options: action_type, dynamics_model, init_steps, control_mode, init_mode
  • Added AGENTS.md with git workflow instructions

Conflict Resolutions

  • Kept 3.0 defaults (256 agents, 8 maps, batch_size=auto)
  • Kept 3.0's ram_tracking feature in vector.py
  • Took PR's new architecture for drive.h, drive.py, binding.c

Test plan

  • Build succeeds locally
  • CI passes
  • Run training experiments
  • Add wandb logs to verify performance

vcharraut and others added 30 commits September 8, 2025 18:38
daphne-cornelisse and others added 27 commits November 11, 2025 13:35
* Make sure we can overwrite goal_behavior from python side and other minor improvements.

* Fix stop goal behavior bug.

* Make goal radius configurable for WOSAC eval.

* Reset to defaults + cleanup.

* Minor

* Minor

* Incorprate feedback.
Accel is being cut in half for no reason
* Add control mode.

* Fix error message.
* Fix incorrect obs dim in draw_agent_obs

* Update drive.h

---------

Co-authored-by: Daphne Cornelisse <cor.daphne@gmail.com>
* make joint action space, currently uses multidiscrete and should be replaced with discrete

* Fix shape mismatch in logits.

* Minor

* Revert: Puffer doesn't like Discrete

* Minor

* Make action dim conditional on dynamics model.

---------

Co-authored-by: Daphne Cornelisse <cor.daphne@gmail.com>
* Replace default learning rate and ent_coef.

* Minor

* Round.
* Quick integration of WOSAC eval during training, will clean up tomorrow.

* Refactor eval code into separate util functions.

* Refactor code to support more eval modes.

* Add human replay evaluation mode.

* Address comments.

* Fix args and add to readme

* Improve and simplify code.

* Minor.

* Reset to default ini settings.
New data format architecture with separated structures:
- Agent, RoadMapElement, TrafficControlElement (replaces Entity/MapEntity)
- Log vs Sim state naming convention
- Route information for path planning
- Traffic light detection and skipping
- New config options: action_type, dynamics_model, init_steps, control_mode, init_mode

Kept 3.0 defaults (256 agents, 8 maps) and ram_tracking feature.
@greptile-apps
Copy link

greptile-apps bot commented Jan 3, 2026

Skipped: This PR changes more files than the configured file change limit: (671 files found, 100 file limit)

@eugenevinitsky eugenevinitsky deleted the merge-pr-107-into-3.0 branch January 3, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.