Fix AnimatedAchievementsBars.lua error#147
Open
FadeOut-9 wants to merge 2 commits intoElvUI-WotLK:masterfrom
Open
Fix AnimatedAchievementsBars.lua error#147FadeOut-9 wants to merge 2 commits intoElvUI-WotLK:masterfrom
FadeOut-9 wants to merge 2 commits intoElvUI-WotLK:masterfrom
Conversation
Fixes Lua error when enabling Progress info. Happens randomly when hovering over people. Error is - Blizzard_AchievementUI\Blizzard_AchievementUI.lua:568: Usage: GetCategoryNumAchievements(categoryID) Fixes ElvUI-WotLK#119 and ElvUI-WotLK#114 Also fixes lua error when enabling Animated Achievement Bars option. Comparing achievements and selecting category Feats of Strength while having no actual achievements there results in an error.
fixes error according to functions inside Blizzard_AchievementUI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Lua error when enabling Progress info. Happens randomly when hovering over people.
Error is - Blizzard_AchievementUI\Blizzard_AchievementUI.lua:568: Usage: GetCategoryNumAchievements(categoryID)
Fixes #119, #114, #99
Also fixes lua error when enabling Animated Achievement Bars option. Comparing achievements and selecting category Feats of Strength while having no actual achievements there results in an error.