Fixes errors in max layout - part 2 #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one of the clients was maximised (like PDF viewer) an error was thrown and visual artifact left on the screen. This patch fixes it by: 1. Making last condition in draw_shape more robust - this fixes the error. 2. Adding missing local variable to change_tag.
If one of the clients was maximised (like PDF viewer) an error was thrown and visual artifact left on the screen. This is the second patch that changes awful.client.tiled to awful.client.visible. Without this change a preview is displayed only for clients in tiled mode but the navigation (left, right) is done on ALL clients (including clients in full screen).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the clients was maximised (like PDF viewer) an error was
thrown and visual artifact left on the screen.
This is the second patch that changes awful.client.tiled to
awful.client.visible.
Without this change a preview is displayed only for clients in tiled mode
but the navigation (left, right) is done on ALL clients (including
clients in full screen).