Skip to content

Conversation

@simone-weiss
Copy link

Changes

Set timestamp to SOURCE_DATE_EPOCH for initrd cpio content. When one exports SOURCE_DATE_EPOCH before calling the initrd generator twice for the same initrd, the built image is binary identical.

Dependencies:

(Provide list of pull requests with dependencies with this pull request)

Tests results

WIP need to implement reproducibility test.

<!-- add Robot test CLI logs here. -->

Developer Checklist:

  • Test: Changes are tested
  • Doc: Documentation has been updated
  • Git: Informative git commit message(s)
  • Issue: If a related GitHub issue exists, linking is done

Checklists for documentation

  • Grammar: the content is grammatically correct
    (spelling, grammar, formatting, US English is used)
  • Comprehensibility/Unambiguousness: the content is easy readable, clear to understand
  • Correctness and consistency: the content is technically correct and consistent,
    no contradictions, no double descriptions
  • Terminology: technical terms are clear and they are used correctly and documented in the glossary
  • Level of detail: the content matches the detail level necessary for the reviewed object

Reviewer checklist:

  • Review: Changes are reviewed
  • Review: Tested by the reviewer

Checklists for documentation

  • Grammar: the content is grammatically correct
    (spelling, grammar, formatting, US English is used)
  • Comprehensibility/Unambiguousness: the content is easy readable, clear to understand
  • Correctness and consistency: the content is technically correct and consistent,
    no contradictions, no double descriptions
  • Terminology: technical terms are clear and they are used correctly and documented in the glossary
  • Level of detail: the content matches the detail level necessary for the reviewed object

Use diffoscope to compare two built initrds process to ensure reproducibility. One can set the python path for robot with:  `robot -P`
@simone-weiss simone-weiss marked this pull request as ready for review February 19, 2025 12:13
types-PyYAML
types-requests

diffoscope
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this may be nice for development and testing, does it really need to be used for comparison, where you would expect the images to always be the same, i.e. just use diff

Library String
Library Collections
Suite Setup Setup
Library OperatingSystem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to reduce the changes (i.e. adding Initrd.in front of a lot of keywords), using

Suggested change
Library OperatingSystem
Library OperatingSystem AS OS

and then OS.Set Environment Variable would be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants