Open
Conversation
Collaborator
nathhandup
commented
Mar 23, 2026
- Renamed files from time -> timing for readability
- changed one functions return value to be a boolean to account for potential failure to grab processor clock time
- implemented both adc and timing.c
Collaborator
Author
|
some things im considering:
|
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
reviewed
Mar 24, 2026
leogmendoza
requested changes
Mar 24, 2026
Collaborator
leogmendoza
left a comment
There was a problem hiding this comment.
adc is mostly good, i just need you to cut some more out of timing
Collaborator
Author
|
Made the requested changes, also renamed files back to time.c and time.h since theres no longer a name conflict without time.h. Still confused about the listed return parameters for the adc.h functions, where it says "True if the measurement is valid, false otherwise". I removed the checks anyways, but are there other checks we should be making? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.