Skip to content

Renames & implementation for timing.c adc.c#9

Open
nathhandup wants to merge 2 commits intomainfrom
Firmware-HAL-Host-adc-time
Open

Renames & implementation for timing.c adc.c#9
nathhandup wants to merge 2 commits intomainfrom
Firmware-HAL-Host-adc-time

Conversation

@nathhandup
Copy link
Copy Markdown
Collaborator

  • Renamed files from time -> timing for readability
  • changed one functions return value to be a boolean to account for potential failure to grab processor clock time
  • implemented both adc and timing.c

@nathhandup
Copy link
Copy Markdown
Collaborator Author

some things im considering:

  • checking for exceeding reverse phase currents
  • checking for some sort of undertemperature?

Copy link
Copy Markdown
Collaborator

@leogmendoza leogmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adc is mostly good, i just need you to cut some more out of timing

@nathhandup
Copy link
Copy Markdown
Collaborator Author

Made the requested changes, also renamed files back to time.c and time.h since theres no longer a name conflict without time.h.

Still confused about the listed return parameters for the adc.h functions, where it says "True if the measurement is valid, false otherwise". I removed the checks anyways, but are there other checks we should be making?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants