Open
Conversation
nathhandup
approved these changes
Mar 26, 2026
nathhandup
reviewed
Mar 28, 2026
| Serial.println("Welcome running"); | ||
| } | ||
|
|
||
| void loop() { |
Collaborator
There was a problem hiding this comment.
loop and setup functions are in main.cpp, change the location of this and then ur good. if u dont see main.cpp on the branch make sure to pull the most recent changes
nathhandup
reviewed
Mar 28, 2026
| gfx->drawRoundRect(10, 230, 252, 78, 14, C_GRAY); | ||
| gfx->setCursor(22, 242); | ||
| gfx->printf("Trip: %.2f km", s.tripKm); | ||
| gfx->setCursor(22, 272); |
Collaborator
There was a problem hiding this comment.
for future practice i'd recomment creating some sort of static values representing text x alignment and y. it makes it helpful if you'd like to translate lots of things at once, because then you only have to change one variable as opposed to a bunch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LCD stats