Skip to content

For JSON decoding, implement process_response instead of process_response_body #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samrat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

For JSON decoding, implement process_response instead of process_response_body #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions lib/hcloud.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ defmodule ClusterHcloud.Hcloud do

use HTTPoison.Base


@api_baseurl "https://api.hetzner.cloud/v1"

@impl true
Expand All @@ -14,8 +13,13 @@ defmodule ClusterHcloud.Hcloud do
end

@impl true
def process_response_body(body) do
Jason.decode!(body)
def process_response(%HTTPoison.Response{status_code: 200, body: body} = response) do
%{response | body: Jason.decode!(body)}
end

@impl true
def process_response(%HTTPoison.Response{} = response) do
response
end

@doc """
Expand All @@ -25,25 +29,32 @@ defmodule ClusterHcloud.Hcloud do
headers = [
authorization_header(access_token)
]

params = %{
label_selector: label_selector,
per_page: 50,
page: page
}

case get("/servers", headers, params: params) do
{:ok, %HTTPoison.Response{body: body, status_code: 200}} ->
results =
Enum.concat(results, body["servers"])

case body["meta"]["pagination"]["next_page"] do
nil ->
{:ok, results}

next_page when is_integer(next_page) ->
servers(access_token, label_selector, next_page, results)

_ ->
{:error, "Malformed pagination information returned from hetzner."}
end

{:ok, %HTTPoison.Response{status_code: status_code}} ->
{:error, "Received status code #{status_code}"}

{:error, %HTTPoison.Error{reason: reason}} ->
{:error, reason}
end
Expand All @@ -57,19 +68,24 @@ defmodule ClusterHcloud.Hcloud do
headers = [
authorization_header(access_token)
]

params = %{
name: network_name
}

case get("/networks", headers, params: params) do
{:ok, %HTTPoison.Response{body: body, status_code: 200}} ->
case body["networks"] do
[first_network | _rest ] ->
[first_network | _rest] ->
{:ok, first_network["id"]}

[] ->
{:error, "Network \"#{network_name}\" not found."}
end

{:ok, %HTTPoison.Response{status_code: status_code}} ->
{:error, "Received status code #{status_code}"}

{:error, %HTTPoison.Error{reason: reason}} ->
{:error, reason}
end
Expand Down