Skip to content

Conversation

@ThomasGoering
Copy link

Short description:
Classes under test (node "covers") in the tests tree were displayed with the cluster hierarchy of the test classes instead of the cluster hierarchy of the classes under test. This is now fixed.

Long description:
This is a fix for my problem report at: https://support.eiffel.com/report_detail/19912

The change that leads to the wrong display of the classes under test in the tree was done with commit 36028ae in class ETEST_CLASS_SYNCHRONIZER, feature add_class_path.

This change leads to the following values of a_tag computed in add_class_path for the two classes TEST_BANK_ACCOUNT and BANK_ACCOUNT (see https://www.eiffel.org/doc/eiffelstudio/The_AutoTest_Interface):

  1. "class/cluster:accounts/cluster:tests/class:TEST_BANK_ACCOUNT" (correct)
  2. "covers/cluster:accounts/cluster:tests/class:BANK_ACCOUNT/feature:deposit" (wrong cluster hierarchy)

My fix changes the computation of a_tag only for tags starting with "covers/" (classes under test). In this case the class object is retrieved by the given class name (instead of using the test class object) without the group/cluster. l_group is not needed here because the class under test is usually not in the test class cluster.

Now these are the values of a_tag:

  1. "class/cluster:accounts/cluster:tests/class:TEST_BANK_ACCOUNT" (unchanged)
  2. "covers/cluster:accounts/class:BANK_ACCOUNT/feature:deposit" (correct cluster hierarchy)

Please review and let me know what you think.

Classes under test (node "covers") in the tests tree were displayed with the cluster hierarchy of the test classes instead of the cluster hierarchy of the classes under test.
This is now fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant