Decompile prep_job_select
#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for YFEE01 (04e1d95 - 57a20cd)📈 Matched code: 5.42% (+0.02%, +356 bytes) ✅ 6 new matches
📈 9 improvements in unmatched functions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decompiles one of the prep-menu sub-states. In this case, it's
sally::JobSwhich I am interpreting to meanjob select(although some files also refer to it asjob slide).This appears to be the
Reclasssubmenu after a unit is selected for reclass.Screenshot:
This uncovers a bit of information, such as:
func_ov002_021f2040-> Starts the battle animation for a given unitsally::JobS+0x38I also sprinkled in some miscellaneous renames/documentation that I had locally, but didn't really have a PR associated with.