chore: make it possible to specify COMMON_OPTIONS for non-Ninja builds a well #7041
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at
edgetx/tools/build-companion.sh
Lines 23 to 31 in 0087e25
COMMON_OPTIONSenvironment variable when invokingtools/build-companion.shwith Ninja generator but not with non-Ninja builds. Being able to specify additional cmake parameters would be helpful for alternative build setups.For example, rpm builds prefer to have all sources packaged in the source rpm rather than fetching them during build time. With this change we could then do things like
rather than a more tedious patching of the
CMakeFiles.txtand*.cmakefiles.Summary of changes:
COMMON_OPTIONSconsumed bytools/build-companion.sh