fix(firmware): potential crash when using multi protocol module.

[philmoz]

Fix stack overflow.

PR #6515 added a longer protocol name.

Fixes #7038

Applies to 2.12 and 3.0.

[pfeerick]

Ouch.

Hm, I'm out atm, but could we add something like this and do away with the need for tmp, etc? Something similar might be handy for in getProtoLabel() since returns a std::string also.

std::string getStringAtIndex(const char *const *s, int idx)
{
  return std::string(s[idx]);
}

rfProto.label = getStringAtIndex(STR_MULTI_PROTOCOLS, pdef->protocol);

[philmoz]

Ouch.

Hm, I'm out atm, but could we add something like this and do away with the need for tmp, etc? Something similar might be handy for in getProtoLabel() since returns a std::string also.

std::string getStringAtIndex(const char *const *s, int idx)
{
  return std::string(s[idx]);
}

rfProto.label = getStringAtIndex(STR_MULTI_PROTOCOLS, pdef->protocol);

Good suggestion. Done.

[pfeerick]

Interesting, goes to show difference between OSes coming to play... prior to this, radio does not crash, Linux simulator does not crash, MacOS simulator does. Anyway radio still doesn't crash and looks to work.