chore(color): implement publish/subscribe messaging to simplify code and further code consolidation #7032
Conversation
philmoz
added
color
pfeerick
left a comment
pfeerick
left a comment
There was a problem hiding this comment.
Liking the code removal and consolidation! Now to find out how many bugs are hiding! 😆
| return confirmed; | ||
| } | ||
|
|
||
| //----------------------------------------------------------------------------- |
There was a problem hiding this comment.
What's the rationale behind these... I can understand at the end of long header lists or to logically divide sections of a file up, but at the end?
radio/src/main.cpp
Outdated
| if (UNEXPECTED_SHUTDOWN()) { | ||
| #if defined(COLORLCD) | ||
| drawFatalErrorScreen(STR_EMERGENCY_MODE); | ||
| backlightEnable(100); |
There was a problem hiding this comment.
Can we not use BACKLIGHT_LEVEL_MAX or BACKLIGHT_FORCED_ON here rather than magic numbers? And the other places where this has been done in this PR?
| if ((BACKLIGHT_LEVEL_MAX - g_eeGeneral.backlightBright) < g_eeGeneral.blOffBright) | ||
| g_eeGeneral.backlightBright = | ||
| BACKLIGHT_LEVEL_MAX - g_eeGeneral.blOffBright; | ||
| #endif |
There was a problem hiding this comment.
Naughty, naughty, this isn't cleanup! lol
There was a problem hiding this comment.
It's to catch any misalignments in old configs. It was being done in the UI code; but only if you edited the backlight settings.
pfeerick
changed the title
pfeerick
changed the title
pfeerick
changed the title
42 |
Changes: