chore: put display settings in hwdefs JSON files.

[philmoz]

Add the display related settings to the hwdefs files.
Update companion to use the settings from the hwdefs files.

@elecpower please check the Companion changes to make sure I've done it correctly.

[elecpower]

@philmoz looks good.

FunctionSwitchGroups - I haven't dug around so just pointing out you changed the logic.

Housekeeping: could you please alphabetise the capability enum and cases. Also checked and MaxAnalogs is redundant so can go. Its last use was for binary import and conversion.

Love your work!

[philmoz]

FunctionSwitchGroups - I haven't dug around so just pointing out you changed the logic.

Based on all the existing cases. Settings for custom switches need to go into JSON at some point (e.g. has RGB leds) so this could also go in the JSON if needed.

Housekeeping: could you please alphabetise the capability enum and cases. Also checked and MaxAnalogs is redundant so can go. Its last use was for binary import and conversion.

Done.

[elecpower]

Based on all the existing cases. Settings for custom switches need to go into JSON at some point (e.g. has RGB leds) so this could also go in the JSON if needed.

I was 99.9% sure you knew what you were doing but hey doesn't hurt to double check. Anything and everything needs to go in hwdef files then Companion should only require maintenance when a new attribute type is added. I can dream can't I...

[philmoz]

Is it safe to remove FactoryInstalledPots and FactoryInstalledSwitches - don't appear to be used?

[elecpower]

Is it safe to remove FactoryInstalledPots and FactoryInstalledSwitches - don't appear to be used?

From memory these are from conversion so if you delete and things compile go for it.

There is a lot of housekeeping post removal of binary support and it is scattered everywhere. So to avoid monster PRs I just keep cleaning up in the areas I'm working on.

[philmoz]

I've added some more settings to the JSON files for custom switches and miscellaneous hardware settings.

There are a few more that will take more time to figure out (HasIMU, HasTrainerModuleCPPM and HasTrainerModuleSBUS).

[elecpower]

Can you also look at the hacks in post load hwdefs in boardsjson which should not be required if hwdefs are complete.

Fantastic work so far. I personally appreciate how this will make life easier maintaining Companion.

[philmoz]

Can you also look at the hacks in post load hwdefs in boardsjson which should not be required if hwdefs are complete.

I don't think those can go just yet - looks to still be some gaps in the other sections of the JSON files.

[elecpower]

I also need to check firmware capabilities in case any hardware related are still hiding out there.

[elecpower]

Reviewed OpenTxFirmware::getCapability and there are lots of hardware items that at a minimum need to be moved to Boards as a housekeeping task. I can foresee multiple PRs for the moves to Boards to keep the merges manageable.

From there you can progressively add to hwdefs.