Fix behaviour of p7_trace_Compare on failed comparison#344
Open
althonos wants to merge 1 commit intoEddyRivasLab:developfrom
Open
Fix behaviour of p7_trace_Compare on failed comparison#344althonos wants to merge 1 commit intoEddyRivasLab:developfrom
p7_trace_Compare on failed comparison#344althonos wants to merge 1 commit intoEddyRivasLab:developfrom
Conversation
althonos
added a commit
to althonos/pyhmmer
that referenced
this pull request
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p7_trace_Compareis a comparison function and is reported to returneslOKon equality andeslFAILotherwise, like other comparison functions (e.g.p7_hmm_Compare). This is also the intended behaviour according to the function documentation:hmmer/src/p7_trace.c
Lines 788 to 793 in bb7c3e1
However, the current implementation instead calls
esl_fatalon any failed equality test and exits the current process.This is not really a problem anywhere given that AFAICT
p7_trace_Compareis only used in unit tests (where the failed comparison would then trigger the sameesl_fatal("FAIL")call anyway), but I noticed in PyHMMER after trying to usep7_trace_Compareto compare traces and seeing my test program forcefully exit.