display import error message #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the display of import error messages in the admin interface modal. The changes ensure that error messages from the server are properly shown to the user with appropriate styling when database import operations fail.
- Added a period to the backend error message for consistency
- Enhanced frontend error handling to display server-side error messages from the JSON response
- Improved UI state management in error scenarios by showing the next steps section and re-enabling the import button
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TEKDB/TEKDB/views.py | Added period to error message string for grammatical consistency |
| TEKDB/TEKDB/static/admin/js/admin_index.js | Enhanced error display with server message extraction, red text styling, and proper UI state management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part 1 of a fix for this bug
This fix addresses the issue of not showing the import error message in the modal. We still need to fix the permissions issue on demo.itkdb.org.