Update session.py #318
Closed
Update session.py #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed save_session_to_file() function
C0rn3j
reviewed
Apr 26, 2025
| def load_session_from_file(self, session_file: Path): | ||
| try: | ||
| with open(session_file) as f: | ||
| with open(session_file, "r") as f: |
Contributor
There was a problem hiding this comment.
Adding this is redundant and linters will scream at you for it:
Collaborator
There was a problem hiding this comment.
This change does not make sense, IMO. We should make use of the Path object and call .open() on it.
C0rn3j
reviewed
Apr 26, 2025
| # "expiry_time": {"data": self.expiry_time}, | ||
| } | ||
| with session_file.open("w") as outfile: | ||
| with open(session_file, "w") as outfile: |
Contributor
There was a problem hiding this comment.
session_file is declared to be a Path object, what's the point of reverting it to the plain open()?
If anything, rest of the code should be converted to Path.
Collaborator
There was a problem hiding this comment.
If anything, rest of the code should be converted to Path.
Agreed
Collaborator
|
Fixed some of the issues mentioned in this MR here: #331 Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed save_session_to_file() function