doc(README): add notes on timestamps for events#26
Open
laurelmay wants to merge 1 commit intoEasyDynamics:mainfrom
Open
doc(README): add notes on timestamps for events#26laurelmay wants to merge 1 commit intoEasyDynamics:mainfrom
laurelmay wants to merge 1 commit intoEasyDynamics:mainfrom
Conversation
|
|
The January meetup was shown as being at 4:30PM ET due to the UTC offset in the front matter being `-04:00` while the current east coast time is `-05:00`. This corrects that for this event (even though it's over) and adds a note to the README and the `event-frontmatter.txt` template file about the correct offsets for Eastern Time, which is likely to be the most relevant timezone for the community. The conversion to local timezone is done in JavaScript so it doesn't really matter what the offset is so long as the overall time is correct but thinking in east coast time is probably the mostly likely mindset for contributors (and causes less friction than requiring all times be specified in UTC).
laurelmay
force-pushed
the
datetime-notes
branch
from
0c50d8f to
31eaec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The January meetup was shown as being at 4:30PM ET due to the UTC offset in the front matter being
-04:00while the current east coast time is-05:00. This corrects that for this event (even though it's over) and adds a note to the README and theevent-frontmatter.txttemplate file about the correct offsets for Eastern Time, which is likely to be the most relevant timezone for the community.The formatting is done client side as well but I am not sure whether there is conversion to the user's
local timezone.