-
Notifications
You must be signed in to change notification settings - Fork 0
[#15] 관광지 조회 응답 수정 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package com.earseo.sight.entity; | ||
|
|
||
| import lombok.AllArgsConstructor; | ||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| @AllArgsConstructor | ||
| public enum SubTheme { | ||
| //자연 | ||
| NA01("자연관광지", "Natural Sites", Theme.NA), | ||
| NA02("관광자원", "Natural Resources", Theme.NA), | ||
|
|
||
| //문화 | ||
| CU01("휴양관광지", "Recreational Sites", Theme.CU), | ||
| CU02("체험관광지", "Experience Programs", Theme.CU), | ||
| CU03("산업관광지", "Industrial Sites", Theme.CU), | ||
| CU04("문화시설", "Cultural Facilities", Theme.CU), | ||
|
|
||
| //예술 | ||
| AR01("축제", "Festivals", Theme.AR), | ||
| AR02("공연/행사", "Events/Performances", Theme.AR), | ||
|
|
||
| //역사 | ||
| HI01("역사관광지", "Historical Sites", Theme.HI), | ||
| HI02("건축/조형물", "Architectural Sights", Theme.HI), | ||
|
|
||
| //레포츠 | ||
| LS01("레포츠소개", "Introduction", Theme.LS), | ||
| LS02("육상 레포츠", "Leisure/Sports (Land)", Theme.LS), | ||
| LS03("수상 레포츠", "Leisure/Sports (Water)", Theme.LS), | ||
| LS04("항공 레포츠", "Leisure/Sports (Sky)", Theme.LS), | ||
| LS05("복합 레포츠", "Leisure/Sports (Others)", Theme.LS), | ||
|
|
||
| //쇼핑 | ||
| SH01("쇼핑", "Shopping", Theme.SH), | ||
| ; | ||
|
|
||
| private final String koName; | ||
| private final String enName; | ||
| private final Theme theme; | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.earseo.sight.entity; | ||
|
|
||
| import lombok.AllArgsConstructor; | ||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| @AllArgsConstructor | ||
| public enum Theme { | ||
| NA("자연", "Nature"), | ||
| CU("문화", "Culture"), | ||
| AR("예술", "Art"), | ||
| HI("역사", "History"), | ||
| LS("레포츠", "Leisure/Sports"), | ||
| SH("쇼핑", "Shopping"), | ||
| ; | ||
|
|
||
| private final String koName; | ||
| private final String enName; | ||
| } |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
관광지 테마와 서브 테마의 이름을 서버측에서 가지고 있을 예정이면, 분류코드를 자연어로 변환하는 API나 전체 코드 & 자연어 쌍을 조회하는 API가 필요할것으로 보입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
프론트에서 enum으로 관리하는 편이 더 좋아보입니다. 이름은 혹시 추후에 어떻게 될지 몰라서 일단 가지고 있으려고 했습니다. 담당자와 상의하고 필요하다면 추가하겠습니다.