Conversation
Closed
3 tasks
Bucoco
reviewed
Jan 7, 2026
Contributor
Bucoco
left a comment
There was a problem hiding this comment.
기존 코드와 다르게 apple만 서비스를 따로 분리해서 로직을 처리한 이유가 궁금합니다. 그리고 구글 로그인 쪽에선 따로 provider id를 사용하지 않는건가요?
Contributor
Author
처음에는 구글이랑 애플이랑 로그인 시 필요한 데이터와 서비스 로직 방식이 다를 것 같아서 분리시켜봤는데 추후에 구글 로그인 작업할때 크게 다르지 않다면 같이 병합해서 작업할 수 있도록 설계하겠습니다 |
Bucoco
approved these changes
Jan 7, 2026
Contributor
Bucoco
left a comment
There was a problem hiding this comment.
provider id가 애플에서만 사용되는 거라면 정규화해서 테이블 분리하는게 좋아보입니다. 고생하셨습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 구현/변경 사항
사용자 시나리오(UML)
🧪 테스트 결과
참고
ApplePublicKey의 각 요소 설명입니다.
keys: 공개키 목록kty: Key Type - "RSA"kid: Key ID - identityToken 헤더의 kid와 매칭해서 어떤 키를 쓸지 결정use: 용도 - "sig" (서명 검증용)alg: Algorithm - "RS256"n: RSA 공개키의 modulus (Base64URL 인코딩)e: RSA 공개키의 exponent (Base64URL 인코딩)AppleTokenVerifier는 토큰 검증과 사용자 정보를 추출하는 역할을 수행합니다
💬 리뷰 받고 싶은 부분 (옵션)