Conversation
- 기존 원본 데이터 json 파싱 및 외부 api 호출에서 외부 api로만 수집 - 다국어 지원(영어) - 변경사항 다수 -> 도슨트쪽도 꼭 보고 리팩토링 준비해야할듯함
- tour api 에서 제공하는 영문 데이터 수집 로직 추가 - tour api rule에 맞게 예외 타입 추가 - 기존 수집 로직 삭제
- 마스터 테이블 변경점 적용 - 영문 도슨트 생성 추가
- 언어와 상관없게 통일
haribonyam
requested review from
Bucoco,
damiiya,
jaewonLeeKOR and
manbron236
Bucoco
reviewed
Jan 22, 2026
Contributor
Bucoco
left a comment
Bucoco
left a comment
There was a problem hiding this comment.
도슨트 쪽 RestClient 빈 주입시 기본 url 설정된 걸 변경하지 않았네요.
컨트롤러 쪽 api path 수정하면서 제가 커밋 올리겠습니다~
Bucoco
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 구현/변경 사항
🧪 테스트 결과
참고
🪞 회고 및 개선 아이디어 (옵션)