chore: Alert dialog implementation

[momshaddinury]

Summary

This MR aims to close #84 .

Other Information

Some unused code was removed.

[tenshiAMD]

@dinurymomshad hi, can you rebase and check if all works fine? thanks

[jorre127]

Add return type and name of the parameter, so final void Function(String name) setExerciseName;

[jorre127]

Maybe work with an enum here that is returned instead of a bool, because now its not entirely clear when "true" is returned for example if this means a redo or a view.

[jorre127]

Work with guard clauses when you can to make code less cluttered and more readable, here for example:

  Future<void> _showViewOrRedoAlertDialog(BuildContext context) async {
    if (!await showViewOrRedoAlertDialog(context)) return addExercises(widget.workout);
    Navigator.of(context).pushReplacement(
      MaterialPageRoute(
        builder: (context) => WorkoutPage(widget.workout),
      ),
    );
  }

[jorre127]

Use final for fields that don't change + guard clause, also be consistent when you want to declare variables, exerciseNameSelection widget gets stored into a variable before being used in the dialog, but the SaveWorkoutContent widget just gets send directly to the dialog.

  void _showAddNewExerciseDialog(BuildContext context) async {
    final exerciseNameSelectionWidget = ExerciseInputField(setExerciseName: setExerciseName);

    if (!await showAddNewExerciseDialog(context, exerciseNameSelectionWidget)) return;
    addExercise();
  }

[jorre127]

Put required parameters first

[jorre127]

Name it something like PresentExtension so you know its an extension from the name.

[jorre127]

Store the theme in a variable at the top of this method so you don't have to call .of(context) every time.

[jorre127]

Maybe not for this PR immediately, but we should store the different textThemes in the theme provided by themeProvider ass well so we don't have 2 themes.

[jorre127]

Defining the type of theme here isn't necessary .

[jorre127]

Personally I think using await is clearer and looks better than using then + const isn't needed here since you're not storing the dialog. Same for the rest of the dialogs (the await not the const)

Future<bool> showDeleteWorkoutDialog(BuildContext context) async {
  final result = await _DeleteDialog(objName: 'workout').present(context);
  return result ?? false;
} 

Or maybe better

Future<bool> showDeleteWorkoutDialog(BuildContext context) async => await _DeleteDialog(objName: 'workout').present(context) ?? false;

[jorre127]

I would maybe have the objName as an optional parameter to the showAddNewExerciesDialog method because otherwise I don't really see the reason it isn't just hardcoded in the constructor above, same for the rest of the dialogs.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

[mergeable]

Lines of code have too many changes. It should be under 500 lines of addtions and deletions.

[mergeable]

Lines of code have too many changes. It should be under 500 lines of addtions and deletions.