Experimental rust support for kirkstone #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
florinmihut
approved these changes
Apr 16, 2025
barsnick
requested changes
Apr 22, 2025
Contributor
barsnick
left a comment
barsnick
left a comment
There was a problem hiding this comment.
Initial remarks.
Testing is not done, pending.
|
|
||
| SRC_URI = "git://github.com/EVerest/everest-framework.git;branch=main;protocol=https \ | ||
| file://0001-Set-PYTHON_MODULE_EXTENSION-to-.so-to-avoid-pollutin.patch \ | ||
| file://0001-Fix-everestrs-build-in-yocto.patch \ |
Contributor
There was a problem hiding this comment.
Is this a patch from upstream, from a PR, or special to Yocto?
| } | ||
|
|
||
| # By default cargo installs the modules into /usr/bin which we do not want and fix here | ||
| do_install:append(){ |
Contributor
There was a problem hiding this comment.
Nit whitespace () {
Suggested change
| do_install:append(){ | |
| do_install:append() { |
| bbnote "Installing EVerest Rust module: ${EVEREST_MODULE}" | ||
| mkdir -p ${D}/usr/libexec/everest/modules/${EVEREST_MODULE} | ||
| mv ${D}/usr/bin/${EVEREST_MODULE} ${D}/usr/libexec/everest/modules/${EVEREST_MODULE} | ||
| cp ${WORKDIR}/git/modules/${EVEREST_MODULE_PATH}/manifest.yaml ${D}/usr/libexec/everest/modules/${EVEREST_MODULE} |
Contributor
There was a problem hiding this comment.
I prefer preserving dates with -p (even if Yocto might modify them later).
Suggested change
| cp ${WORKDIR}/git/modules/${EVEREST_MODULE_PATH}/manifest.yaml ${D}/usr/libexec/everest/modules/${EVEREST_MODULE} | |
| cp -p ${WORKDIR}/git/modules/${EVEREST_MODULE_PATH}/manifest.yaml ${D}/usr/libexec/everest/modules/${EVEREST_MODULE} |
| @@ -0,0 +1,80 @@ | |||
| LICENSE = "Apache-2.0" | |||
Contributor
There was a problem hiding this comment.
Why is this recipe's file name unversioned, while everest-core's is versioned?
| crate://crates.io/zerofrom/0.1.5 \ | ||
| crate://crates.io/zerofrom-derive/0.1.5 \ | ||
| crate://crates.io/zerovec/0.10.4 \ | ||
| crate://crates.io/zerovec-derive/0.10.3 \ |
Contributor
There was a problem hiding this comment.
I hope this isn't a maintenance nightmare, but I have no experience with Rust recipes. 😅
| if ${@bb.utils.contains('PACKAGECONFIG', 'rust', 'true', 'false', d)}; then | ||
| bbnote "everest-framework rust support enabled" | ||
| mkdir -p ${D}${datadir}/everest | ||
| cp -R ${WORKDIR}/git/everestrs ${D}${datadir}/everest/ |
Contributor
There was a problem hiding this comment.
Preserve, so -rp or the well-known -a.
Suggested change
| cp -R ${WORKDIR}/git/everestrs ${D}${datadir}/everest/ | |
| cp -a ${WORKDIR}/git/everestrs ${D}${datadir}/everest/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.