Fix bug in ClearChargingProfile.req #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file id was specified Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
hikinggrass
reviewed
Nov 21, 2024
lib/ocpp/v16/charge_point_impl.cpp
Outdated
| } else if (this->smart_charging_handler->clear_all_profiles_with_filter( | ||
| } else if (!call.msg.id and | ||
| this->smart_charging_handler->clear_all_profiles_with_filter( | ||
| call.msg.id, call.msg.connectorId, call.msg.stackLevel, call.msg.chargingProfilePurpose, false)) { |
Member
There was a problem hiding this comment.
since call.msg.id must be std::nullopt (because of the!call.msg.id in the if) at this point maybe you can directly pass std::nullopt for call.msg.if` here which would make this a bit more readable
Pietfried
commented
Nov 21, 2024
Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>
hikinggrass
approved these changes
Nov 21, 2024
Pietfried
added a commit
that referenced
this pull request
Nov 25, 2024
* Fixed issue that other charging profiles were cleared even when a profile id was specified --------- Signed-off-by: Piet Gömpel <pietgoempel@gmail.com> Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixed issue that other charging profiles were cleared even when a profile id was specified
Issue ticket number and link
Checklist before requesting a review