Skip to content

Add clang-tidy config and associated fixes #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hikinggrass merged 74 commits into from
Dec 10, 2025
Merged

Add clang-tidy config and associated fixes #1159

hikinggrass merged 74 commits into from
Dec 10, 2025

Conversation

@hikinggrass
Copy link
Member

@hikinggrass hikinggrass commented Nov 27, 2025

Describe your changes

This replaces PR #1146

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • If OCPP 2.0.1 or OCPP2.1: I have updated the OCPP 2.x status document
  • I read the contribution documentation and made sure that my changes meet its requirements

@hikinggrass
Add clang-tidy config
e27213e 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix clang-format config to always keep qualifiers aligned left
bd0fc78 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Update gitignore file
dc9d31a 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix doxygen comment formatting on generated files
2612ee1 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix header guard
84bec6d 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use const refs in generated messages and types
c6716b3 
Prefer .empty() to .size() == 0 in generated messages

Remove include that is not needed from 1.6 ocpp types

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use const (ref) where possible
ade4503 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use explicit comparisons in if statements and prefer empty() to size(…
0da2471 
…) == 0

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use = default for ctors and use override for virtual functions
5abbbfc 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use ctor initializer list
af0de49 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Do not declare multiple variables at once
4514ecf 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Initialize members and variables
a089d90 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use using instead of typedef
9a39eb0 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Simplify if/else handling, eg. no use of else after return
e6d200e 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use stoul instead of atoi
2578082 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix missing value in enum declaration
c162d3e 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add clamp_to and convert_to_positive_size_t utils functions
41d1032 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use anonymous namespace instead of static
6d12cfd 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use enum class instead of enum
1a8909c 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
remove repeating visibilities
f870412 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix parameter names not being identical in hpp and cpp
8eb99ea 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
remove redundant inline
e855c0c 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Access static member via class not this
1f1f748 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use move
6d0606a 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Make log_on_fail static
0e90f07 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix size_t usage in profile
102cd08 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix includes
7e2797b 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use std::is_same_v
e00d560 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add readability NOLINT comments
6d46530 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Reserve space in containers
d69c5da 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix type of variable
c76826d 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
clang-format
8c80858 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Merge remote-tracking branch 'origin/main' into bugfix/clang-tidy-fixes
2f75948 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Ensure that time isn't called with a 0 interval
1b54951 
This prevents a divisin by 0 error caused by logging

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use std::(u)int(32/64) everywhere instead of the non-std version
6418c99 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Moved implementations
f46f533 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Move = default into header
e5b9357 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add logs during caught exceptions
9439c02 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Refactor wildcard X509 host check into its own function
039a25e 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fall through switch-case, remove NOLINT statements
3150683 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use bool_to_string for boolean config item
59e3713 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Refactor max_recurrency_duration initialization
1cede30 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add warnings to status info
fdd1c7a 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix typos
0e5bfbc 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Use const where possible
a50ddfc 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix unchecked optional access
b59d508 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add missing else-if that is already upstream
8304111 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
hikinggrass
hikinggrass commented Dec 1, 2025
View reviewed changes
Copy link
Member Author

@hikinggrass hikinggrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlitre I've addressed your comments from the old PR and updated the branch from main

@hikinggrass hikinggrass changed the title Bugfix/clang tidy fixes Add clang-tidy config and associated fixes Dec 1, 2025
@hikinggrass
clang-format
5dfe03c 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Merge remote-tracking branch 'origin/main' into bugfix/clang-tidy-fixes
ee733e9 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Revert "Modify drop_transaction_data algorithm to fix some clang-tidy…
a270cac 
… issues"

This reverts commit b21fbee.

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Update defaults in MessageQueueConfig
efef0c8 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass hikinggrass merged commit fa0e66f into main Dec 10, 2025
9 of 10 checks passed
@hikinggrass hikinggrass deleted the bugfix/clang-tidy-fixes branch December 10, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlitre mlitre mlitre approved these changes

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

@marcemmers marcemmers Awaiting requested review from marcemmers marcemmers is a code owner

Assignees

@mlitre mlitre

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hikinggrass @mlitre