[OCPP 1.6] Add support for updating OCPP config via method calls #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-ctc
requested review from
Pietfried,
hikinggrass,
marcemmers and
mlitre
as code owners
Merged
3 tasks
feat: set custom key removed and replaced with set key This allows all OCPP 1.6 keys to be set via EVerest internal and stable APIs Signed-off-by: James Chapman <james.chapman@pionix.de>
When some keys are updated then an action is performed. This commit ensures the same actions are preformed regardless of where the update comes from (method call or OCPP) Signed-off-by: James Chapman <james.chapman@pionix.de>
Signed-off-by: James Chapman <james.chapman@pionix.de>
james-ctc
force-pushed
the
dev/jc-ocpp-16-config-update
branch
from
7a8ea31 to
d0e2b30
Compare
fix: set configurtaion now returns optional This enables the set function to result nullopt when the key to set doesn't match any expected values. Previously accepted was returned for unknown keys. Signed-off-by: James Chapman <james.chapman@pionix.de>
james-ctc
force-pushed
the
dev/jc-ocpp-16-config-update
branch
from
d0e2b30 to
4957555
Compare
Pietfried
requested changes
Nov 24, 2025
| /// \return Indicates the result of the operation | ||
| ConfigurationStatus set_custom_configuration_key(CiString<50> key, CiString<500> value); | ||
| ConfigurationStatus set_configuration_key(CiString<50> key, CiString<500> value); | ||
| std::pair<ConfigurationStatus, std::optional<ChangeConfigurationResponse>> |
Contributor
There was a problem hiding this comment.
looks like this function can be private
Member
Author
There was a problem hiding this comment.
updated to make set_configuration_key_internal private
Pietfried
approved these changes
Nov 24, 2025
james-ctc
force-pushed
the
dev/jc-ocpp-16-config-update
branch
from
3737c3a to
18a814a
Compare
Signed-off-by: James Chapman <james.chapman@pionix.de>
james-ctc
force-pushed
the
dev/jc-ocpp-16-config-update
branch
from
18a814a to
797bf8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In OCPP 1.6 previously only custom configuration could be updated via method calls.
This updated allows method calls to update OCPP configuration with the same processing that would occur had the request been via OCPP.
(similar to #1152 but for main)
Issue ticket number and link
Checklist before requesting a review