libiso15118: -2 dc messages #1679
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 17, 2025 09:14
These structs are a common part in many messages. Signed-off-by: Kacper Dalach <kdalach@elektrometal.com.pl>
Signed-off-by: Kacper Dalach <kdalach@elektrometal.com.pl>
Signed-off-by: Kacper Dalach <kdalach@elektrometal.com.pl>
Dalachowsky
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass,
james-ctc and
mlitre
as code owners
added 5 commits
December 19, 2025 13:18
Signed-off-by: Kacper Dalach <kdalach@elektrometal.com.pl>
Added datatypes that are common among DC messages. Signed-off-by: Kacper Dalach <kdalach@elektrometal.com.pl>
Signed-off-by: Kacper Dalach <kdalach@elektrometal.com.pl>
Signed-off-by: Kacper Dalach <kdalach@elektrometal.com.pl>
Signed-off-by: Kacper Dalach <kdalach@elektrometal.com.pl>
Dalachowsky
force-pushed
the
feat/adding-iso2-support-dc-messages
branch
from
8679f60 to
dacfb7d
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added all messages specified in 8.4.5 DC-Messages section of ISO15118-2 along with tests. Messages for tests were generated using libcbv2g, thus some values might seem absurd.
Files from
src/iso15118/message/d2directory have 100% test coverage.The
MeterInfoconvert()functions do not have 100% coverage. Only the case where all fields are present is covered.Issue ticket number and link
Checklist before requesting a review