feat: Over-voltage monitor implementation in EVSEManager #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florinmihut
force-pushed
the
feat/over_voltage_monitor
branch
from
6053980 to
002042a
Compare
florinmihut
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass,
james-ctc and
mlitre
as code owners
florinmihut
force-pushed
the
feat/over_voltage_monitor
branch
from
399af37 to
0c7e14b
Compare
florinmihut
changed the title
florinmihut
force-pushed
the
feat/over_voltage_monitor
branch
from
ac31dda to
ad21486
Compare
Pietfried
requested changes
Dec 16, 2025
| void OverVoltageMonitor::set_limits(double emergency_limit, double error_limit) { | ||
| emergency_limit_ = emergency_limit; | ||
| error_limit_ = error_limit; | ||
| limits_valid_ = true; |
Contributor
There was a problem hiding this comment.
If it is not verified if limits are plausible limits_valid is not needed
Contributor
Author
There was a problem hiding this comment.
Theoretically update_voltage is not called before set_limits but to avoid potential false errors I would argue to leave it to be on the safe side. Not sure how in the future we need to change the flow and shielding checking against invalid limits is not necessary a bad thing.
Pietfried
force-pushed
the
feat/over_voltage_monitor
branch
from
d08682d to
01e1f3c
Compare
…VSEManager Implementation of an internal over-voltage monitor on top of the external one. This is a safety mechanism that reads the measured values received from over-voltage monitor and raises the over voltage faults (in case the external one is not reacting correctly). There 2 limits that can be set: an error and an emergency limit. In case of an voltage over the error limit, we are checking if this is just a very short peak or it will stay over 400ms (default value - configurable). If at the end of the 400ms we stayed above the error limit, we trigger the MREC50OverVoltage error. In case of an voltage over the emergency error, we trigger ASAP the MREC50OverVoltage fault.Implementation of an internal over-voltage monitor on top of the external one. This is a safety mechanism that reads the measured values received from over-voltage monitor and raises the over voltage faults (in case the external one is not reacting correctly). There 2 limits that can be set: an error and an emergency limit. In case of an voltage over the error limit, we are checking if this is just a very short peak or it will stay over 400ms (default value - configurable). If at the end of the 400ms we stayed above the error limit, we trigger the MREC50OverVoltage error. In case of an voltage over the emergency error, we trigger ASAP the MREC50OverVoltage fault. Signed-off-by: Florin Mihut <florinmihut1@gmail.com>
Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Co-authored-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com> Signed-off-by: florinmihut <florinmihut1@gmail.com>
Co-authored-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com> Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: Florin Mihut <florinmihut1@gmail.com>
Co-authored-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com> Signed-off-by: florinmihut <florinmihut1@gmail.com>
…VSEManager Implementation of an internal over-voltage monitor on top of the external one. This is a safety mechanism that reads the measured values received from over-voltage monitor and raises the over voltage faults (in case the external one is not reacting correctly). There 2 limits that can be set: an error and an emergency limit. In case of an voltage over the error limit, we are checking if this is just a very short peak or it will stay over 400ms (default value - configurable). If at the end of the 400ms we stayed above the error limit, we trigger the MREC50OverVoltage error. In case of an voltage over the emergency error, we trigger ASAP the MREC50OverVoltage fault.Implementation of an internal over-voltage monitor on top of the external one. This is a safety mechanism that reads the measured values received from over-voltage monitor and raises the over voltage faults (in case the external one is not reacting correctly). There 2 limits that can be set: an error and an emergency limit. In case of an voltage over the error limit, we are checking if this is just a very short peak or it will stay over 400ms (default value - configurable). If at the end of the 400ms we stayed above the error limit, we trigger the MREC50OverVoltage error. In case of an voltage over the emergency error, we trigger ASAP the MREC50OverVoltage fault. Signed-off-by: Florin Mihut <florinmihut1@gmail.com>
…VSEManager Implementation of an internal over-voltage monitor on top of the external one. This is a safety mechanism that reads the measured values received from over-voltage monitor and raises the over voltage faults (in case the external one is not reacting correctly). There 2 limits that can be set: an error and an emergency limit. In case of an voltage over the error limit, we are checking if this is just a very short peak or it will stay over 400ms (default value - configurable). If at the end of the 400ms we stayed above the error limit, we trigger the MREC50OverVoltage error. In case of an voltage over the emergency error, we trigger ASAP the MREC50OverVoltage fault.Implementation of an internal over-voltage monitor on top of the external one. This is a safety mechanism that reads the measured values received from over-voltage monitor and raises the over voltage faults (in case the external one is not reacting correctly). There 2 limits that can be set: an error and an emergency limit. In case of an voltage over the error limit, we are checking if this is just a very short peak or it will stay over 400ms (default value - configurable). If at the end of the 400ms we stayed above the error limit, we trigger the MREC50OverVoltage error. In case of an voltage over the emergency error, we trigger ASAP the MREC50OverVoltage fault. Signed-off-by: Florin Mihut <florinmihut1@gmail.com>
Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: florinmihut <florinmihut1@gmail.com>
Signed-off-by: Florin Mihut <florinmihut1@gmail.com>
Co-authored-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com> Signed-off-by: florinmihut <florinmihut1@gmail.com>
florinmihut
force-pushed
the
feat/over_voltage_monitor
branch
from
b54d0df to
aaa0d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implementation of an internal over-voltage monitor on top of the external one. This is a safety mechanism that reads the measured values received from over-voltage monitor and raises the over voltage faults (in case the external one is not reacting correctly).
There 2 limits that can be set: an error and an emergency limit.
In case of an voltage over the error limit, we are checking if this is just a very short peak or it will stay over 400ms (default value - configurable). If at the end of the 400ms we stayed above the error limit, we trigger the MREC50OverVoltage error.
In case of an voltage over the emergency error, we trigger ASAP the MREC50OverVoltage fault.
Issue ticket number and link
Checklist before requesting a review