-
Notifications
You must be signed in to change notification settings - Fork 7
Add language support #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add language support #337
Conversation
- Using "vue-i18n" as basis. - Introducing a language selector in the top right of the UI. - Introducing a locale identifier in the URL, e.g. http://localhost:8080/#/en/connect - Modifying "update-simulator-data.js" to generate labels and extract English descriptions to English locale files. - Adding two demo languages German "de" and Chinese (simplified) "zh" Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…ue." Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
592f403 to
c499cb5
Compare
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…lly fixing error "Unsafe call of an `error` typed value". Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…d value." linter error by using safe patterns. Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
|
I'm struggling to conquer the Codacy Static Code Analysis results. Part of the problem is that it seems to be using a different set of ESlint settings from what is available in the repo. When I run Also, Codacy's output provides no detail on what exactly in the source is violating the "Unsafe call of an error type typed value" rule. I've tried to cast and narrow the types involved, but all to no avail. |
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
… path information." Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…checks Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…t of an error typed value." error Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
This reverts commit 549e176. Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…type typed value." Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…on line 53 Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…rror Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
… to a parameter of type `{}`."
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…iteral variable in a util.format / console.log function." Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…signed to a parameter of type `{}`."
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…n Sink" error persists. Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…rol data in `Object.assign` can cause web response to include data that it should not have or can lead to a mass assignment vulnerability." Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
|
I've brought the number of errors in the Codacy Static Code Analysis down to 10. All of which are in parts of the code that I did not touch. It feels like the code in this repo got security checks bolted on at some point in time, but it was never brought up to scratch accordingly. My pull request is the first non-bot pull request that is actually being validated, and therefore it gets all the violations that were embedded in the code already. My suggestions:
I'll try to bring down the number of errors to 0 as best I can. That being said, these "Generic Object Injection Sink" and "Unsafe call of an |
… the rule where safe. Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…h to help Codacy's linting. Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…ped value." Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
…ess .interface on an `error` typed value." error Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Signed-off-by: Patrick Atoon <patrick.atoon@gmail.com>
Implements language support as described in #336.