Skip to content

Conversation

@MarcImberger
Copy link

Drop unsupported python 3.9, add 3.12 and 3.13, remove cap on xarray

@SchmJo SchmJo self-requested a review November 27, 2025 09:47
@SchmJo
Copy link
Contributor

SchmJo commented Nov 27, 2025

Thanks for this, I removed the Python version limit in the pyproject.toml as well

@SchmJo SchmJo assigned SchmJo and kilojoules and unassigned SchmJo Nov 27, 2025
@SchmJo
Copy link
Contributor

SchmJo commented Nov 27, 2025

The tests fail due to another issue, discussed in #32

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 3.9 is supported to my knowledge - I tested the installation locally on my computer, and also during testing the installation works

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was more thinking about the end-of-live of python 3.9 (no need to support it anymore or make things backwards compatible)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is also a good point. I will discuss this with the team, thanks. My personal philosophy is to drop deprecated Python versions as soon as they cause trouble

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Python version to >=3.9,<3.14 such that it now includes 3.12 and 3.13. But 3.9 also seems to be supported, according to my testing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep testing 3.9 until it breaks

@kilojoules
Copy link
Member

LGTM. Let's merge main in to this branch before we merge this into main. All tests must pass before we merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep testing 3.9 until it breaks

"Development Status :: 3 - Alpha",
]
requires-python = ">=3.9,<3.12"
requires-python = ">=3.9,<3.14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good provided we can pass tests in these python envs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants