Skip to content

Further improved cases where objects were unnecessarily reused or copied. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanFellner merged 3 commits into from
Jan 13, 2026
Merged

Further improved cases where objects were unnecessarily reused or copied. #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b1d324
UCAAS-1211 Further improved cases where objects were unnecessarily re…
JanFellner Jan 13, 2026
4c728d8
UCAAS-1211 Bumped to new version 6.0.37
JanFellner Jan 13, 2026
e417934
UCAAS-1211 Updated output files to reflect the newest version
JanFellner Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/back-ends/ts-gen/gluecode/SNACCROSE.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
/*
* SNACCROSE.ts
* "SNACC-ROSE" ASN.1 stubs.
* This file was generated by estos esnacc (V6.0.36, 12.01.2026)
* This file was generated by estos esnacc (V6.0.37, 13.01.2026)
* based on Coral WinSnacc written by Deepak Gupta
* NOTE: This is a machine generated file - editing not recommended
*/
Expand Down
2 changes: 1 addition & 1 deletion compiler/back-ends/ts-gen/gluecode/SNACCROSE_Converter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
/*
* SNACCROSE_Converter.ts
* "SNACC-ROSE" ASN.1 stubs.
* This file was generated by estos esnacc (V6.0.36, 12.01.2026)
* This file was generated by estos esnacc (V6.0.37, 13.01.2026)
* based on Coral WinSnacc written by Deepak Gupta
* NOTE: This is a machine generated file - editing not recommended
*/
Expand Down
2 changes: 1 addition & 1 deletion cpp-lib/include/SNACCROSE.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//
// SNACCROSE.h - class definitions for ASN.1 module SNACC-ROSE
//
// This file was generated by estos esnacc (V6.0.36, 12.01.2026)
// This file was generated by estos esnacc (V6.0.37, 13.01.2026)
// based on Coral WinSnacc written by Deepak Gupta
// NOTE: This is a machine generated file - editing not recommended
//
Expand Down
3 changes: 1 addition & 2 deletions cpp-lib/include/asn-listset.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,9 @@ template <class T> void AsnList<T>::BDecContent(const SNACC::AsnBuf& b, SNACC::A
template <class T> void AsnList<T>::JEnc(SJson::Value& b) const
{
b = SJson::Value(SJson::arrayValue);
SJson::Value tmp;

for (auto i = this->cbegin(); i != this->cend(); ++i)
{
SJson::Value tmp;
i->JEnc(tmp);
b.append(tmp);
}
Expand Down
2 changes: 1 addition & 1 deletion cpp-lib/src/SNACCROSE.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//
// SNACCROSE.cpp - class member functions for ASN.1 module SNACC-ROSE
//
// This file was generated by estos esnacc (V6.0.36, 12.01.2026)
// This file was generated by estos esnacc (V6.0.37, 13.01.2026)
// based on Coral WinSnacc written by Deepak Gupta
// NOTE: This is a machine generated file - editing not recommended
//
Expand Down
38 changes: 8 additions & 30 deletions cpp-lib/src/asn-optionalparam.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,23 +35,19 @@ void AsnOptionalParameters::JEnc(SJson::Value& b) const
{
/*
b = SJson::Value(SJson::arrayValue);
SJson::Value tmp;

for (AsnOptionalParameters::const_reverse_iterator i = rbegin(); i != rend(); ++i)
{
SJson::Value tmp;
i->JEnc(tmp);
b.append(tmp);
}
*/
b = SJson::Value(SJson::objectValue);
SJson::Value tmp;

for (AsnOptionalParameters::const_reverse_iterator i = rbegin(); i != rend(); ++i)
{
i->value.JEnc(tmp);
std::string key;
i->key.getUTF8(key);
b[key] = tmp;
i->value.JEnc(b[key]);
}
}

Expand Down Expand Up @@ -205,14 +201,8 @@ AsnLen AsnOptionalParam::BEnc(AsnBuf& _b) const
void AsnOptionalParam::JEnc(SJson::Value& b) const
{
b = SJson::Value(SJson::objectValue);

SJson::Value tmp;

key.JEnc(tmp);
b["key"] = tmp;

value.JEnc(tmp);
b["value"] = tmp;
key.JEnc(b["key"]);
value.JEnc(b["value"]);
}

void AsnOptionalParam::BDec(const AsnBuf& _b, AsnLen& bytesDecoded)
Expand All @@ -233,7 +223,6 @@ bool AsnOptionalParam::JDec(const SJson::Value& b)
if (!b.isObject())
return false;

SJson::Value tmp;
if (b.isMember("key"))
{
if (!key.JDec(b["key"]))
Expand Down Expand Up @@ -429,25 +418,17 @@ void AsnOptionalParamChoice::JEnc(SJson::Value& b) const
/*
b = SJson::Value(SJson::objectValue);

SJson::Value tmp;

switch (choiceId)
{
case stringdataCid:
stringdata->JEnc (tmp);
b["stringdata"] = tmp;
stringdata->JEnc(b["stringdata"]);
break;

case binarydataCid:
binarydata->JEnc (tmp);
b["binarydata"] = tmp;
binarydata->JEnc(b["binarydata"]);
break;

case integerdataCid:
integerdata->JEnc (tmp);
b["integerdata"] = tmp;
integerdata->JEnc(b["integerdata"]);
break;

default:
throw EXCEPT("Choice is empty", ENCODE_ERROR);
} // end switch
Expand All @@ -461,9 +442,7 @@ void AsnOptionalParamChoice::JEnc(SJson::Value& b) const
case binarydataCid:
{
b = SJson::Value(SJson::objectValue);
SJson::Value tmp;
binarydata->JEnc(tmp);
b["binarydata"] = tmp;
binarydata->JEnc(b["binarydata"]);
break;
}

Expand Down Expand Up @@ -495,7 +474,6 @@ bool AsnOptionalParamChoice::JDec(const SJson::Value& b)
Clear();
if (b.isObject())
{
SJson::Value tmp;
if (b.isMember("stringdata"))
{
choiceId = stringdataCid;
Expand Down
6 changes: 3 additions & 3 deletions version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#ifndef VERSION_H
#define VERSION_H

#define VERSION "6.0.36"
#define VERSION_RC 6, 0, 36
#define RELDATE "12.01.2026"
#define VERSION "6.0.37"
#define VERSION_RC 6, 0, 37
#define RELDATE "13.01.2026"

#endif // VERSION_H