Corrections related to CESM/CTSM coupling #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmizukami
added
cesm-coupling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes related to cesm coupling:
Previously the coupling frequency was allowed to be more than 1 day because
coupling_periodwas integer and unit of the coupling frequency was set to day in nuopc. Here, the type ofcoupling_periodwas changed to real and unit of frequency is set to sec. This allows us to use sub-daily coupling frequency and also make the code slightly cleaner (removed some lines)Also there was bug (wrong loop index variable) when checking the outlet reach, which is fixed here. This fix seems to enable mizuRoute to run in fully CESM coupled mode without crash.
Fix #594