Conversation
Think the parseInt is throwing off the computeMaxVals calculation, and thus throwing off the correct lengths of the bars for each value. Changing to parseFloat should fix it.
📚 Storybook preview (updated to ff5e98b) |
Trying out a scaling solution - depending on length of numbers we need to represent, we scale the possible length of the bar charts to account for the text we need to fit.
Did the scaling the wrong way, this starts at 90% of the length of the cell for values with 2 digits, then subtracts 3% for each additional digit past that.
Think this causes issues when _value might be an integer or float instead of string, so need to ensure it's a string to check the number of digits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Think the parseInt is throwing off the computeMaxVals calculation, and thus throwing off the correct lengths of the bars for each value. Changing to parseFloat should fix it.