Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

close app on filler plugin failure #32

Open
klimrmad wants to merge 1 commit into
base: master
Choose a base branch
from
Open

close app on filler plugin failure #32

klimrmad wants to merge 1 commit into from

Conversation

@klimrmad
Copy link

@klimrmad klimrmad commented Jul 10, 2019

There is no reason to keep app running in case of filler plugin failure.

@tbfleming
Copy link
Contributor

tbfleming commented Jul 10, 2019

There are a couple problems with this approach:

  • This isn't the correct way to shutdown appbase
  • This will shutdown an app which is running both a filler and wasm-ql. This may not be desirable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@klimrmad @tbfleming