-
Notifications
You must be signed in to change notification settings - Fork 2
style: formatting non-python files #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR is now ready for review @psomhorst |
psomhorst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaniBodor Have you tested this? You say the PR will automatically be closed when the PR is merged, but there is no 'merge PR' action, only a 'merge branches' action. I cannot find any documentation on this automatically closing the PR.
See #338 for an alternative way explicitly merge a PR.
If the PR is automatically closed, it should also remove the branch. This means the last action should be superfluous as well.
That's a good point. I suggest moving forward with either this branch (where the old close line could be changed to a mark as merged line) or with #338, but not both. Either way, we should probably create a fork and test that it works as intended. Let me know which solution you prefer. |
according to example on website
d9f6de7 to
319c860
Compare
|
@psomhorst , I've removed the changes to the github release workflow from this PR, so now it is just some minor style changes. |
EDIT: I repurposed this PR to do only the tidying up stuff, and the not-closing PRs on release part is now handled by #338
5d075b5: removed one step from the github release workflow that marks PRs as "closed". They should be automatically marked as "merged" in the preceeding job, when the PR is actually merged.