fix deprecation warning for DataFrame.swapaxes #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
|
@EBjerrum do you have anything to add or we can merge that and publish new version? |
Owner
|
No comments, it looks good. Thanks for the effort @kbarbary! Do you want to be listed in the Readme?, then please add yourself in the readme under contributions, both in the root dir and the docs/index file. |
EBjerrum
approved these changes
May 4, 2025
Owner
|
Do pull from master if you want to edit the readme as there was a recent correction. |
kbarbary
force-pushed
the
fix-pandas-dep-warning
branch
from
f55fee0 to
8a091d7
Compare
Contributor
Author
|
Thanks for the review. Added myself to the contributors lists in 8a091d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes deprecation warnings about
DataFrame.swapaxes, detailed in #49.This deprecation warning arises from calling
np.array_split()on a DataFrame. Unfortunately it will not be fixed between numpy and pandas, as detailed in numpy/numpy#24889 (comment). It seems that in the future it may return ndarrays instead of DataFrames.The fix here is one possible implementation: for pandas objects, split the integer index values, then apply them to the pandas object using
iloc.Thanks for the great package, by the way!