EVA-3959 Check species name is in correct format #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
reviewed
Oct 15, 2025
|
|
||
| String[] dbNameParts = species.split("_", 2); | ||
|
|
||
| if (dbNameParts.length != 2) { |
Member
There was a problem hiding this comment.
I think it is possible to have more than two parts in which case everything after the first underscore is the assembly accession (see uoa_wb_1)
Contributor
Author
There was a problem hiding this comment.
We are splitting by giving an upper limit of 2 here String[] dbNameParts = species.split("_", 2);, so we can't have more than 2 parts. uoa_wb_1 will split into uoa and wb_1.
apriltuesday
approved these changes
Oct 16, 2025
tcezard
approved these changes
Oct 17, 2025
|
|
||
| String[] dbNameParts = species.split("_", 2); | ||
|
|
||
| if (dbNameParts.length != 2) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.