EVA-3776 Update eva-seqcol to final version of the specification #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitin-ebi
force-pushed
the
update_to_latest_specification
branch
from
016caa9 to
03da6cb
Compare
tcezard
approved these changes
Mar 20, 2025
| }, | ||
| "required": [ | ||
| "names", | ||
| "lengths", |
Member
There was a problem hiding this comment.
Actually Length is still required. See https://ga4gh.github.io/refget/seqcol/#1-schema-defining-the-attributes-in-the-collection
Contributor
apriltuesday
left a comment
apriltuesday
left a comment
There was a problem hiding this comment.
Guess there's a couple more changes to be done, but code-wise this looks good so far 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.