Skip to content

fix: handle restore warning responses in upload UI #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lil-aditya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle restore warning responses in upload UI #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 37 additions & 15 deletions WebAPP/Classes/Base.Class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,26 @@ export class Base {
static uploadFunction = function () {
Dropzone.autoDiscover = false;

const handleCaseRestoreSuccess = function (result, showWarning = false) {
let casename = result.casename;
if (casename) {
Html.apendModel(casename);
}

Message.bigBoxSuccess("Upload response", result.message, null);
if (showWarning && result.message_warning) {
Message.warningOsy(result.message_warning);
}

$('#modalrestore').modal('toggle');
if (Base.AWS_SYNC == 1 && casename) {
SyncS3.deleteResultsPreSync(casename)
.then(response => {
SyncS3.uploadSync(casename);
});
}
};

var MyDropzone = new Dropzone("#myDropzone", {
//url: "http://127.0.0.1:5000/upload",
url: Base.apiUrl() + "uploadCase",
Expand Down Expand Up @@ -270,22 +290,24 @@ export class Base {
// },
success: function (file, response) {
console.log('response ', response )

if (response.response[0]['status_code'] == 'success') {
let casename = response.response[0]['casename'];
console.log('casename ', casename )
Html.apendModel(casename);
Message.bigBoxSuccess("Upload response", response.response[0]['message'], null);
//value.previewElement.innerHTML = "";
$('#modalrestore').modal('toggle');
if (Base.AWS_SYNC == 1) {
SyncS3.deleteResultsPreSync(casename)
.then(response => {
SyncS3.uploadSync(casename);
});
}
} else if (response.response[0]['status_code'] == 'warning') {
const result = response.response && response.response[0];

if (!result) {
Message.bigBoxDanger("Upload response", "Upload completed but returned an unexpected response.", null);
return;
}

if (result['status_code'] == 'success') {
console.log('casename ', result['casename'])
handleCaseRestoreSuccess(result);
} else if (result['status_code'] == 'warning') {
if (result.message_warning) {
handleCaseRestoreSuccess(result, true);
} else {
Message.bigBoxWarning("Upload response", result['message'], null);
}
} else if (result['status_code'] == 'error') {
Message.bigBoxDanger("Upload response", result['message'], null);
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The success callback has no fallback for unexpected/malformed status_code values (or a missing status_code). In that case the handler will silently do nothing, which undermines the new defensive handling. Consider adding a final else that shows a danger/warning message (and optionally logs the payload) so users aren’t left with no UI feedback when the response shape changes.

Suggested change
Message.bigBoxDanger("Upload response", result['message'], null);
Message.bigBoxDanger("Upload response", result['message'], null);
} else {
console.warn('Unexpected upload response status_code', result);
Message.bigBoxWarning("Upload response", "Upload completed but returned an unexpected status.", null);

Copilot uses AI. Check for mistakes.
}
// $.each(file, function (key, value) {
// if (response.response[key]['status_code'] == 'success') {
Expand Down
Loading