Fix logically impossible condition in updateTEViewData when TechId an…#414
Open
mohityadav8 wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
Fix logically impossible condition in updateTEViewData when TechId an…#414mohityadav8 wants to merge 1 commit intoEAPD-DRB:mainfrom
mohityadav8 wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
…d EmisId are both provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d EmisId are both provided
Linked issue
Existing related work reviewed
Overlap assessment
updateTEViewData().Why this PR should proceed
TechIdandEmisIdare provided.Summary
What changed:
kwas compared against bothTechIdandEmisId.TechIdandEmisIdas nested keys in the JSON structure.Why:
Falsewhen both parameters were provided, preventing the update from executing.Validation
Documentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)Exception rationale