fix: preserve original exception type in FileClass write methods#411
Open
Anirudh77715 wants to merge 2 commits intoEAPD-DRB:mainfrom
Open
fix: preserve original exception type in FileClass write methods#411Anirudh77715 wants to merge 2 commits intoEAPD-DRB:mainfrom
Anirudh77715 wants to merge 2 commits intoEAPD-DRB:mainfrom
Conversation
This fixes an issue where IOError were swallowed and incorrectly re-raised as IndexError in writeFile and writeFileUJson. Closes EAPD-DRB#353
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where IOError exceptions were swallowed and incorrectly re-raised as IndexError in writeFile and writeFileUJson.
Linked issue
Existing related work reviewed
Overlap assessment
Why this PR should proceed
Both
writeFile()andwriteFileUJson()catch(IOError, IndexError)but unconditionally re-raise asIndexError, masking the original exception type. When anIOErroroccurs during file write, callers seeIndexErrorinstead — making debugging misleading. Using bareraisepreserves the original exception type and traceback.Summary
raise IndexErrorwith bareraisein bothwriteFile()andwriteFileUJson()inAPI/Classes/Base/FileClass.pyraisepreserves the correct exception typeValidation
Documentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)Exception rationale