fix(#356): add session null-check to download endpoints#364
Closed
Anirudh77715 wants to merge 1 commit intoEAPD-DRB:mainfrom
Closed
fix(#356): add session null-check to download endpoints#364Anirudh77715 wants to merge 1 commit intoEAPD-DRB:mainfrom
Anirudh77715 wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
Download endpoints (downloadDataFile, downloadFile, downloadCSVFile, downloadResultsFile, downloadCSV) crashed with TypeError when no case session was set because None was passed to Path(). Now each endpoint validates the session and returns a 400 JSON error if no case is active.
Collaborator
|
@Anirudh77715 Thanks for the work here. I’m closing this in favor of #416, which we’re keeping as the current implementation PR for the missing-session download crash tracked under #240. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download endpoints crashed with TypeError when no case session was set because None was passed to Path().
Linked issue
Existing related work reviewed
Overlap assessment
Why this PR should proceed
session.get('osycase', None)returnsNone→Path(None)raisesTypeError→ uncaught → HTML 500 for all download endpoints. This PR adds a session null-check guard returning a 400 JSON error instead.Summary
DataFileRoute.pyandCaseRoute.pyPath(None)raisesTypeErrorcausing uncaught 500 errors on all download routes when no case session existsValidation
Documentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)Exception rationale